RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx [v3]

[Leslie Zhai]

On Wed, 14 Sep 2022 15:41:12 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Leslie Zhai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8293535: Revert test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java
>
> The edit to `JavadocTester` is inappropriate.

Hi @jonathan-gibbons 

Thanks for your review!

> The edit to `JavadocTester` is inappropriate.

I updated my patch. Please review it again.

Thanks,
Leslie Zhai

> test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 836:
> 
>> 834:     public void checkOrder(String path, String... strings) {
>> 835:         new OutputChecker(path)
>> 836:                 .setExpectOrdered(false) // TODO, fix tests (6 failures) and change to true
> 
> This is not good, and affects any tests using this method.
> 
> It would be better to fix the test failures, or to modify the test to avoid calling this method. (i.e. move the TODO there, not here)

Done

-------------

PR: https://git.openjdk.org/jdk/pull/10217