RFR: JDK-8312445: Array types in annotation elements show square brackets twice [v3]

[Pavel Rappo]

On Wed, 26 Jul 2023 10:50:16 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Please review a change to fix the representation of array types as values of annotation elements in javadoc-generated documentation.
>> 
>> The primary fix is to avoid generating duplicate `[]` brackets for array types, but there are a few secondary improvements:
>> 
>>  - When linking to a type, only use the type name as link label, appending the `.class` as plain text after the link
>>  - Support linking to the base type of array types, again appending the square brackets and `.class` after the link
>>  - Leave it to the `LinkFactory` code to decide whether to use the qualified or simple type name for a link (uses `isLinkable` instead of `isIncluded`)
>> 
>> There already was some test code for the use of array types in annotation elements in `TestNewLanguageFeatures.java`, but it was disabled with a comment referring to another issue that has long been resolved.
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add test case for link generation with multi-dimensional array type

Looks good.

-------------

Marked as reviewed by prappo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15019#pullrequestreview-1547483617