Integrated: JDK-8312445: Array types in annotation elements show square brackets twice

Hannes Wallnöfer hannesw at openjdk.org
Wed Jul 26 13:07:58 UTC 2023


On Tue, 25 Jul 2023 13:29:55 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> Please review a change to fix the representation of array types as values of annotation elements in javadoc-generated documentation.
> 
> The primary fix is to avoid generating duplicate `[]` brackets for array types, but there are a few secondary improvements:
> 
>  - When linking to a type, only use the type name as link label, appending the `.class` as plain text after the link
>  - Support linking to the base type of array types, again appending the square brackets and `.class` after the link
>  - Leave it to the `LinkFactory` code to decide whether to use the qualified or simple type name for a link (uses `isLinkable` instead of `isIncluded`)
> 
> There already was some test code for the use of array types in annotation elements in `TestNewLanguageFeatures.java`, but it was disabled with a comment referring to another issue that has long been resolved.

This pull request has now been integrated.

Changeset: 02a04731
Author:    Hannes Wallnöfer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/02a04731b1b2e68bf1a79f50d036bedd032128f0
Stats:     40 lines in 4 files changed: 18 ins; 6 del; 16 mod

8312445: Array types in annotation elements show square brackets twice

Reviewed-by: prappo

-------------

PR: https://git.openjdk.org/jdk/pull/15019


More information about the javadoc-dev mailing list