RFR: 8317621: --add-script should support JavaScript modules [v2]
Jonathan Gibbons
jjg at openjdk.org
Wed May 15 22:08:03 UTC 2024
On Wed, 15 May 2024 13:08:39 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Please review an enhancement to detect [JavaScript modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) when added to `javadoc` with the `--add-script` option, which require a different `type` attribute in the HTML `<script>` element. The main method of detection is to scan the script content for `import` and `export` statements. The `*.mjs` extension is also recognized, although it is rarely used for browser modules.
>>
>> I have tested the recognition against scripts and modules in projects such as [Angular](https://github.com/angular/angular) and [Mermaid](https://github.com/mermaid-js/mermaid) and it worked quite well in detecting JavaScript modules.
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review feedback
I'm not sure about the name of the new method, but do not as yet have any better suggestion, so OK.
-------------
Marked as reviewed by jjg (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18546#pullrequestreview-2059095979
More information about the javadoc-dev
mailing list