Integrated: 8317621: --add-script should support JavaScript modules
Hannes Wallnöfer
hannesw at openjdk.org
Fri May 17 12:39:09 UTC 2024
On Fri, 29 Mar 2024 09:39:18 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
> Please review an enhancement to detect [JavaScript modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) when added to `javadoc` with the `--add-script` option, which require a different `type` attribute in the HTML `<script>` element. The main method of detection is to scan the script content for `import` and `export` statements. The `*.mjs` extension is also recognized, although it is rarely used for browser modules.
>
> I have tested the recognition against scripts and modules in projects such as [Angular](https://github.com/angular/angular) and [Mermaid](https://github.com/mermaid-js/mermaid) and it worked quite well in detecting JavaScript modules.
This pull request has now been integrated.
Changeset: 9bb6169a
Author: Hannes Wallnöfer <hannesw at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/9bb6169a1cba900fa79d63119696efe265762083
Stats: 209 lines in 3 files changed: 196 ins; 3 del; 10 mod
8317621: --add-script should support JavaScript modules
Reviewed-by: jjg
-------------
PR: https://git.openjdk.org/jdk/pull/18546
More information about the javadoc-dev
mailing list