RFR: 8342808: Javadoc should add whitespace between type parameters [v5]

Nizar Benalla nbenalla at openjdk.org
Tue Nov 26 12:18:21 UTC 2024


> EDIT: Here are the [generated docs](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8342808/docs/api/index.html) after the latest changes.
> 
> Please review this patch to render javadocs as `<K, V, T>` rather than `<K,V,T>` to match naming conventions and make the rendered output slighly nicer to read.
> 
> Passes langtool tests.
> 
> The [generated docs](https://cr.openjdk.org/~nbenalla/GeneratedDocs/K-V-space/docs/api/index.html) only include `java.base`.
> 
> Note for reviewers:
> 
> In `TestInheritence`, B is a user defined class and `TypeMirror::getKind` returns `DECLARED `. Which why we see this output. 
> 
> 
> 
> html
> 
> Class D<R,S>
> java.lang.Object
> [pkg.A](https://htmledit.squarefree.com/A.html)<S, [B](https://htmledit.squarefree.com/B.html)>
> [pkg.B](https://htmledit.squarefree.com/B.html)<S, [B](https://htmledit.squarefree.com/B.html)>
> pkg.D<R,S>

Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:

  -rename boundTypeParam variable as that's not the primary condition used
  -Remove TYPE_PARAMS_MAX_INLINE_LENGTH
  -use a constant rather than a magic number

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21759/files
  - new: https://git.openjdk.org/jdk/pull/21759/files/2b1caf0b..694063cf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21759&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21759&range=03-04

  Stats: 12 lines in 3 files changed: 3 ins; 3 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/21759.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21759/head:pull/21759

PR: https://git.openjdk.org/jdk/pull/21759


More information about the javadoc-dev mailing list