RFR: 8342808: Javadoc should add whitespace between type parameters [v5]

Hannes Wallnöfer hannesw at openjdk.org
Tue Nov 26 16:32:39 UTC 2024


On Tue, 26 Nov 2024 12:18:21 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> EDIT: Here are the [generated docs](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8342808/docs/api/index.html) after the latest changes.
>> 
>> Please review this patch to render javadocs as `<K, V, T>` rather than `<K,V,T>` to match naming conventions and make the rendered output slighly nicer to read.
>> 
>> Passes langtool tests.
>> 
>> The [generated docs](https://cr.openjdk.org/~nbenalla/GeneratedDocs/K-V-space/docs/api/index.html) only include `java.base`.
>> 
>> Note for reviewers:
>> 
>> In `TestInheritence`, B is a user defined class and `TypeMirror::getKind` returns `DECLARED `. Which why we see this output. 
>> 
>> 
>> 
>> html
>> 
>> Class D<R,S>
>> java.lang.Object
>> [pkg.A](https://htmledit.squarefree.com/A.html)<S, [B](https://htmledit.squarefree.com/B.html)>
>> [pkg.B](https://htmledit.squarefree.com/B.html)<S, [B](https://htmledit.squarefree.com/B.html)>
>> pkg.D<R,S>
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   -rename boundTypeParam variable as that's not the primary condition used
>   -Remove TYPE_PARAMS_MAX_INLINE_LENGTH
>   -use a constant rather than a magic number

Thanks, looks good!

-------------

Marked as reviewed by hannesw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21759#pullrequestreview-2462075393


More information about the javadoc-dev mailing list