RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to subproceses

[PM]

On Tue, 2 Jul 2024 10:38:27 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> No longer passing any -agentlib to subprocesses, unless it is part of -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as expected:
> 
> java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005  -jar tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"
> 
> works.

Changes requested by matcdac at github.com (no known OpenJDK username).

jcstress-core/src/main/java/org/openjdk/jcstress/Options.java line 400:

> 398:     public static List<String> filterAgentLib(List<String> originalArgs ) {
> 399:         return originalArgs.stream().filter(s -> !s.startsWith("-agentlib")).collect(Collectors.toList());
> 400:     }

the name of the method is `filterAgentLib` , but its returning the list of string that don't start with `-agentlib` , correction required here

jcstress-core/src/main/java/org/openjdk/jcstress/vm/VMSupport.java line 398:

> 396: 
> 397:     private static Config cleanArgs(Config orig) {
> 398:         List<String> l = Options.filterAgentLib(orig.args);

can you directly do the filtering here by writing the logic, instead of defining a static method in the Options class, since every other method in Options class is at instance level and non-static

-------------

PR Review: https://git.openjdk.org/jcstress/pull/150#pullrequestreview-2154388676
PR Review Comment: https://git.openjdk.org/jcstress/pull/150#discussion_r1662872100
PR Review Comment: https://git.openjdk.org/jcstress/pull/150#discussion_r1662878734