RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to subproceses [v2]

Jiří Vaněk jvanek at openjdk.org
Wed Jul 3 08:49:42 UTC 2024


On Tue, 2 Jul 2024 16:54:56 GMT, PM <duke at openjdk.org> wrote:

>> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restricted -agentlib:jdwp filtering
>
> jcstress-core/src/main/java/org/openjdk/jcstress/Options.java line 400:
> 
>> 398:     public static List<String> filterAgentLib(List<String> originalArgs ) {
>> 399:         return originalArgs.stream().filter(s -> !s.startsWith("-agentlib")).collect(Collectors.toList());
>> 400:     }
> 
> the name of the method is `filterAgentLib` , but its returning the list of string that don't start with `-agentlib` , correction required here

Hi! I made it ab it more strict (`-agentlib:jdwp`)  and renamed the method.

-------------

PR Review Comment: https://git.openjdk.org/jcstress/pull/150#discussion_r1663804795


More information about the jcstress-dev mailing list