jcstress-dev Digest, Vol 71, Issue 1
Prakhar Makhija
matcdac at gmail.com
Tue Jul 2 17:35:40 UTC 2024
Hello Team,
Provided review comments for both *openjdk/jcstress PRs : #149 *and* #150*
https://github.com/openjdk/jcstress/pull/149
https://github.com/openjdk/jcstress/pull/150
Regards,
*Prakhar Makhija*
+91 78294 00970
matcdac at gmail.com
https://www.linkedin.com/in/prakhar-makhija-17794b107/
On Tue, Jul 2, 2024 at 4:13 PM <jcstress-dev-request at openjdk.org> wrote:
> Send jcstress-dev mailing list submissions to
> jcstress-dev at openjdk.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://mail.openjdk.org/mailman/listinfo/jcstress-dev
> or, via email, send a message with subject or body 'help' to
> jcstress-dev-request at openjdk.org
>
> You can reach the person managing the list at
> jcstress-dev-owner at openjdk.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of jcstress-dev digest..."
>
>
> Today's Topics:
>
> 1. RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings (Ji?? Van?k)
> 2. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v2] (Ji?? Van?k)
> 3. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings (Ji?? Van?k)
> 4. RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging
> parameters to subproceses (Ji?? Van?k)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 19 Jun 2024 13:03:31 GMT
> From: Ji?? Van?k <jvanek at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings
> Message-ID:
> <tsWR1P-0JoBFGek8MbzKehzzm65t3BYK7LYzLMhfn58=.
> 53203e9e-f223-4a4c-a406-ee53a14149b6 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> This is extracting List<TestConfig> configs =prepareRunProgram(classes,
> tests);
> with all he HW/switches setup to separated method and reusing it in `-l`
> mode
>
> I'm aware of triplicated removal of -agentlib, and will clean it up as
> CODETOOLS-7903756 will progress.
>
> -l now honours also verbose mode, in which it prints not just matching
> tests but all really run tests, and thus enabling much more easy
> determining of all tests
>
> help adjusted.
>
> Maybe I'm missing plain quick initial all tests metod now, but with
> artificial -c MAX it seems doing exactly that
>
> -------------
>
> Commit messages:
> - CODETOOLS-7903748 - jcstress: Test list should honor concurrency
> settings
> - CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to
> subproceses
>
> Changes: https://git.openjdk.org/jcstress/pull/149/files
> Webrev: https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=00
> Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903748
> Stats: 103 lines in 6 files changed: 76 ins; 18 del; 9 mod
> Patch: https://git.openjdk.org/jcstress/pull/149.diff
> Fetch: git fetch https://git.openjdk.org/jcstress.git
> pull/149/head:pull/149
>
> PR: https://git.openjdk.org/jcstress/pull/149
>
>
> ------------------------------
>
> Message: 2
> Date: Tue, 2 Jul 2024 07:38:57 GMT
> From: Ji?? Van?k <jvanek at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v2]
> Message-ID:
> <yf-RhtSU9E7vVUj6I3ixiFQUdUNQA7IihlhIv11swcU=.
> 67df85e6-a732-4ffb-942e-ef3fc41878a1 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> > This is extracting List<TestConfig> configs =prepareRunProgram(classes,
> tests);
> > with all he HW/switches setup to separated method and reusing it in `-l`
> mode
> >
> > I'm aware of triplicated removal of -agentlib, and will clean it up as
> > CODETOOLS-7903756 will progress.
> >
> > -l now honours also verbose mode, in which it prints not just matching
> > tests but all really run tests, and thus enabling much more easy
> > determining of all tests
> >
> > help adjusted.
> >
> > Maybe I'm missing plain quick initial all tests metod now, but with
> > artificial -c MAX it seems doing exactly that
>
> Ji?? Van?k has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains one
> new commit since the last revision:
>
> CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings
>
> This is extracting List<TestConfig> configs =prepareRunProgram(classes,
> tests);
> with all he HW/switches setup to separated method and reusing it in `-l`
> mode
>
> -l now honours also verbose mode, in which it prints not just matching
> tests but all really run tests, and thus enabling much more easy
> determining of all tests
>
> help adjusted.
>
> Maybe I'm missing plain quick initial all tests metod now, but with
> artificial -c MAX it seems doing exactly that
>
> -------------
>
> Changes:
> - all: https://git.openjdk.org/jcstress/pull/149/files
> - new:
> https://git.openjdk.org/jcstress/pull/149/files/a52df414..58455e2d
>
> Webrevs:
> - full: https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=01
> - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=00-01
>
> Stats: 4 lines in 3 files changed: 0 ins; 2 del; 2 mod
> Patch: https://git.openjdk.org/jcstress/pull/149.diff
> Fetch: git fetch https://git.openjdk.org/jcstress.git
> pull/149/head:pull/149
>
> PR: https://git.openjdk.org/jcstress/pull/149
>
>
> ------------------------------
>
> Message: 3
> Date: Tue, 2 Jul 2024 07:38:57 GMT
> From: Ji?? Van?k <jvanek at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings
> Message-ID:
> <EqHUX9rfzYzgrPi83cDp6rTC9cTzaDREaLICLk3mFgY=.
> 87b05cfc-eeb5-4082-96f8-e4b73ccf1da3 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Wed, 19 Jun 2024 12:58:28 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:
>
> > This is extracting List<TestConfig> configs =prepareRunProgram(classes,
> tests);
> > with all he HW/switches setup to separated method and reusing it in `-l`
> mode
> >
> > I'm aware of triplicated removal of -agentlib, and will clean it up as
> > CODETOOLS-7903756 will progress.
> >
> > -l now honours also verbose mode, in which it prints not just matching
> > tests but all really run tests, and thus enabling much more easy
> > determining of all tests
> >
> > help adjusted.
> >
> > Maybe I'm missing plain quick initial all tests metod now, but with
> > artificial -c MAX it seems doing exactly that
>
> Removed the unrelated commit. Ping please?
>
> -------------
>
> PR Comment:
> https://git.openjdk.org/jcstress/pull/149#issuecomment-2202178960
>
>
> ------------------------------
>
> Message: 4
> Date: Tue, 2 Jul 2024 10:42:54 GMT
> From: Ji?? Van?k <jvanek at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging
> parameters to subproceses
> Message-ID:
> <Lpr8mKtEiSMrWRYbNuk5uyAcQJ4T9STFe1QLCisdKPo=.
> 9b65936c-24ac-4cfc-a0d8-0c1ea55d999a at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> No longer passing any -agentlib to subprocesses, unless it is part of
> -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as
> expected:
>
> java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005
> -jar tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend
> "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"
>
> works.
>
> -------------
>
> Commit messages:
> - CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to
> subproceses
>
> Changes: https://git.openjdk.org/jcstress/pull/150/files
> Webrev: https://webrevs.openjdk.org/?repo=jcstress&pr=150&range=00
> Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903756
> Stats: 14 lines in 3 files changed: 13 ins; 0 del; 1 mod
> Patch: https://git.openjdk.org/jcstress/pull/150.diff
> Fetch: git fetch https://git.openjdk.org/jcstress.git
> pull/150/head:pull/150
>
> PR: https://git.openjdk.org/jcstress/pull/150
>
>
> End of jcstress-dev Digest, Vol 71, Issue 1
> *******************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jcstress-dev/attachments/20240702/53110cbc/attachment-0001.htm>
More information about the jcstress-dev
mailing list