RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to subproceses [v2]

Jiří Vaněk jvanek at openjdk.org
Wed Jul 3 08:52:32 UTC 2024


On Tue, 2 Jul 2024 16:59:40 GMT, PM <duke at openjdk.org> wrote:

>> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restricted -agentlib:jdwp filtering
>
> jcstress-core/src/main/java/org/openjdk/jcstress/vm/VMSupport.java line 398:
> 
>> 396: 
>> 397:     private static Config cleanArgs(Config orig) {
>> 398:         List<String> l = Options.filterAgentLib(orig.args);
> 
> can you directly do the filtering here by writing the logic, instead of defining a static method in the Options class, since every other method in Options class is at instance level and non-static

Sure. That was leftower. I had moved the method directly ty VMSupport.java and made it private.
Unless you insists I would like to keep method in. I will inline it with comment if you say anyway.

-------------

PR Review Comment: https://git.openjdk.org/jcstress/pull/150#discussion_r1663810557


More information about the jcstress-dev mailing list