RFR: CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings [v4]

[PM]

On Wed, 3 Jul 2024 08:33:44 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> This is extracting  List<TestConfig> configs =prepareRunProgram(classes, tests);
>> with all he HW/switches setup to separated method and reusing it in `-l` mode
>> 
>> I'm aware of triplicated removal of -agentlib, and will clean it up as
>> CODETOOLS-7903756 will progress.
>> 
>> -l now honours also verbose mode, in which it prints not just matching
>> tests but all really run tests, and thus enabling much more easy
>> determining of all tests
>> 
>> help adjusted.
>> 
>> Maybe I'm missing plain quick initial all tests metod now, but with 
>> artificial -c MAX it seems doing exactly that
>
> Jiří Vaněk has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Moved listing of tests to separate method: listTests
>  - -l description moved to constant

Changes requested by matcdac at github.com (no known OpenJDK username).

jcstress-core/src/main/java/org/openjdk/jcstress/Options.java line 50:

> 48: public class Options {
> 49: 
> 50:     private static final String LIST_OPTION_DESCRIPTION="List the available tests matching the requested settings, after all filters (like CPU count) are applied. In verbose mode it prints all real combinations which will run.";

feel free to split this in two lines if you prefer, you are right on the readability aspect, anyways the concatenation would happen just once at the application startup

jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/TestConfig.java line 264:

> 262:                 ", strideCount: " + strideCount +
> 263:                 ", cpuMap: " + cpuMap +
> 264:                 ", " + jvmArgs + "}";

kindly modify this to return a valid json, perhaps try running this method locally once in your machine, and copy paste that json in any online json formatter to check if you encounter any errors

-------------

PR Review: https://git.openjdk.org/jcstress/pull/149#pullrequestreview-2157193321
PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1664653397
PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1664644334