RFR: CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings [v4]

Jiří Vaněk jvanek at openjdk.org
Thu Jul 4 05:49:57 UTC 2024


On Wed, 3 Jul 2024 19:30:06 GMT, PM <duke at openjdk.org> wrote:

>> Jiří Vaněk has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Moved listing of tests to separate method: listTests
>>  - -l description moved to constant
>
> jcstress-core/src/main/java/org/openjdk/jcstress/Options.java line 50:
> 
>> 48: public class Options {
>> 49: 
>> 50:     private static final String LIST_OPTION_DESCRIPTION="List the available tests matching the requested settings, after all filters (like CPU count) are applied. In verbose mode it prints all real combinations which will run.";
> 
> feel free to split this in two lines if you prefer, you are right on the readability aspect, anyways the concatenation would happen just once at the application startup

thanx! Split.

-------------

PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1665155175


More information about the jcstress-dev mailing list