jcstress-dev Digest, Vol 71, Issue 8
Prakhar Makhija
matcdac at gmail.com
Thu Jul 4 08:37:22 UTC 2024
Hello Team,
Approved *openjdk/jcstress PR : #149*
https://github.com/openjdk/jcstress/pull/149
Both *openjdk/jcstress PR : **#149* and *#150* are *Ready for Integration*
https://github.com/openjdk/jcstress/pull/149
https://github.com/openjdk/jcstress/pull/150
Whoever has access kindly update the labels by removing `rfr` and adding
`ready` ; and can proceed further for the process of merge
Regards,
*Prakhar Makhija*
+91 78294 00970
matcdac at gmail.com
https://www.linkedin.com/in/prakhar-makhija-17794b107/
On Thu, Jul 4, 2024 at 1:42 PM <jcstress-dev-request at openjdk.org> wrote:
> Send jcstress-dev mailing list submissions to
> jcstress-dev at openjdk.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://mail.openjdk.org/mailman/listinfo/jcstress-dev
> or, via email, send a message with subject or body 'help' to
> jcstress-dev-request at openjdk.org
>
> You can reach the person managing the list at
> jcstress-dev-owner at openjdk.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of jcstress-dev digest..."
>
>
> Today's Topics:
>
> 1. Re: RFR: CODETOOLS-7903756 - jcstress shuld not pass
> debugging parameters to subproceses [v4] (PM)
> 2. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v6] (Ji?? Van?k)
> 3. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v5] (Ji?? Van?k)
> 4. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v4] (Ji?? Van?k)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 4 Jul 2024 08:04:38 GMT
> From: PM <duke at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: Re: RFR: CODETOOLS-7903756 - jcstress shuld not pass
> debugging parameters to subproceses [v4]
> Message-ID:
> <_7lwZ8HeK3Nzl8W8RzRWRB2hxib4tWP67nobrFmxKIw=.
> 29566c3e-a475-465a-bd6c-3680ba8c0db0 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Thu, 4 Jul 2024 06:25:05 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:
>
> >> No longer passing any -agentlib to subprocesses, unless it is part of
> -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as
> expected:
> >>
> >> java
> -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005 -jar
> tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend
> "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"
> >>
> >> works.
> >
> > Ji?? Van?k has updated the pull request incrementally with one
> additional commit since the last revision:
> >
> > Removed unused imports
>
> looks good to me, ready to merge
>
> -------------
>
> Marked as reviewed by matcdac at github.com (no known OpenJDK username).
>
> PR Review:
> https://git.openjdk.org/jcstress/pull/150#pullrequestreview-2158252745
>
>
> ------------------------------
>
> Message: 2
> Date: Thu, 4 Jul 2024 08:11:44 GMT
> From: Ji?? Van?k <jvanek at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v6]
> Message-ID:
> <f0Df3-A9l-TXj1_XH8SXSZkDfSk6vmFMI7OdHUXfdiM=.
> e81a5b67-57f2-4127-8fc0-c61e1b664984 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> > This is extracting List<TestConfig> configs =prepareRunProgram(classes,
> tests);
> > with all he HW/switches setup to separated method and reusing it in `-l`
> mode
> >
> > I'm aware of triplicated removal of -agentlib, and will clean it up as
> > CODETOOLS-7903756 will progress.
> >
> > -l now honours also verbose mode, in which it prints not just matching
> > tests but all really run tests, and thus enabling much more easy
> > determining of all tests
> >
> > help adjusted.
> >
> > Maybe I'm missing plain quick initial all tests metod now, but with
> > artificial -c MAX it seems doing exactly that
>
> Ji?? Van?k has updated the pull request incrementally with one additional
> commit since the last revision:
>
> replaced long string concatenation with StringBuilder
>
> -------------
>
> Changes:
> - all: https://git.openjdk.org/jcstress/pull/149/files
> - new:
> https://git.openjdk.org/jcstress/pull/149/files/713c5a2d..4ee850d8
>
> Webrevs:
> - full: https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=05
> - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=04-05
>
> Stats: 15 lines in 1 file changed: 3 ins; 0 del; 12 mod
> Patch: https://git.openjdk.org/jcstress/pull/149.diff
> Fetch: git fetch https://git.openjdk.org/jcstress.git
> pull/149/head:pull/149
>
> PR: https://git.openjdk.org/jcstress/pull/149
>
>
> ------------------------------
>
> Message: 3
> Date: Thu, 4 Jul 2024 08:11:44 GMT
> From: Ji?? Van?k <jvanek at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v5]
> Message-ID:
> <oF8OhnErRbWFpZKPrEQSH7ytHK3yJ0c_Hg1kxDytquQ=.
> 057a5990-538c-4bab-9331-1680b65c283b at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Thu, 4 Jul 2024 05:49:57 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:
>
> >> This is extracting List<TestConfig> configs
> =prepareRunProgram(classes, tests);
> >> with all he HW/switches setup to separated method and reusing it in
> `-l` mode
> >>
> >> I'm aware of triplicated removal of -agentlib, and will clean it up as
> >> CODETOOLS-7903756 will progress.
> >>
> >> -l now honours also verbose mode, in which it prints not just matching
> >> tests but all really run tests, and thus enabling much more easy
> >> determining of all tests
> >>
> >> help adjusted.
> >>
> >> Maybe I'm missing plain quick initial all tests metod now, but with
> >> artificial -c MAX it seems doing exactly that
> >
> > Ji?? Van?k has updated the pull request incrementally with one
> additional commit since the last revision:
> >
> > LIST_OPTION_DESCRIPTION split to two lines
>
> Sorry for forced, push, that was typo in commit message
>
> -------------
>
> PR Comment:
> https://git.openjdk.org/jcstress/pull/149#issuecomment-2208365304
>
>
> ------------------------------
>
> Message: 4
> Date: Thu, 4 Jul 2024 08:11:44 GMT
> From: Ji?? Van?k <jvanek at openjdk.org>
> To: <jcstress-dev at openjdk.org>
> Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor
> concurrency settings [v4]
> Message-ID:
> <ettMqxF3_9U5MDHcAdwtuP0yh6K-22bx-toPJXGJfg0=.
> ebd770fa-da01-4e6c-90af-e81902be185f at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Thu, 4 Jul 2024 07:55:45 GMT, PM <duke at openjdk.org> wrote:
>
> >> I never had an intention to return valid json. It is used only in
> verbose output, to differentiate individual variants of tests. Wihtout the
> test id, it do no have sense, and the extended info in {} is...
> complicated. See eg:
> >>
> >> org.openjdk.jcstress.samples.api.API_01_Simple {[actor1, actor2],
> spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB:
> 64, compileMode: 0, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256,
> strideCount: 40, cpuMap: null, [-XX:+UseBiasedLocking]}
> >> org.openjdk.jcstress.samples.api.API_01_Simple {[actor1, actor2],
> spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB:
> 64, compileMode: 0, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256,
> strideCount: 40, cpuMap: null, [-XX:-UseBiasedLocking]}
> >>
> >>
> >>
> >> To highlight it is not json, was the original usage of `=`, but I did
> not had super strong opinion.
> >> As the output should remain mainly human readable, I'm quite against
> full json (thus bracket before name, and id before actorNames and
> jvmArgs). But on contrary, the list is indeed huge.
> >>
> >> All matching tests combinations - 3030696
> >> x
> >> All matching tests - 4483
> >>
> >> with most of the combinations.
> >>
> >> The main motivation is the line of ""All matching tests combinations -
> " + testsToPrint.size()" thus real number of run tests. The listing itself
> is (very) useful candy on top:
> >>
> >> java -jar tests-all/target/jcstress.jar -v -l -t
> org.openjdk.jcstress.samples.api.API_01_Simple
> >> ...
> >> All matching tests combinations - 96
> >> ...
> >>
> >> x
> >>
> >> java -jar tests-all/target/jcstress.jar -l -t
> org.openjdk.jcstress.samples.api.API_01_Simple
> >> ...
> >> All matching tests - 1
> >> ...
> >>
> >>
> >>
> >> So back to verbose listing output format - I intentionally kept it semi
> parse-able - grep/sed on output, and readable enough: name info in {} ,
> all fields with key id, and obvious arrays in [] without key.
> >> **AFAICJ, the full json will lower the human readability.**
> >>
> >> What about this - with "-v" it would print it as it is - human
> readable, fully distinguishible. on "-vv or -vvv" it would print complete
> fully qulified json. WDYT?
> >
> > ok sure, gotcha, the human readable output with `-v` option what you are
> printing right now should be fine, just one small change I would request,
> instead of doing string concatenation with the `+` operator, can we use
> append operation with String Builder or String Buffer whichever is more
> appropriate here
>
> Thanx, done!
> Maybe.. can I return back the "=" instead of ": " ?
>
> -------------
>
> PR Review Comment:
> https://git.openjdk.org/jcstress/pull/149#discussion_r1665308861
>
>
> End of jcstress-dev Digest, Vol 71, Issue 8
> *******************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jcstress-dev/attachments/20240704/c54c886b/attachment-0001.htm>
More information about the jcstress-dev
mailing list