RFR: 7903750: TimeBudget (-tb) does not fulfill its promisses [v8]

Jiří Vaněk jvanek at openjdk.org
Mon Jun 23 08:22:32 UTC 2025


> Added warning, when time budget is to small, and final run will run at least two times longer.

Jiří Vaněk has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - Removed duplicated construcion of timebudget
 - directly return new instance without intermediate variable
   
   Co-authored-by: Galder Zamarreño <galder at redhat.com>
 - Removed table like formatting for time budget warnning
 - Removed unnecesasary NPE check in getTimeBudget
   
   The NPE workaround was causing NPE to be only delayed for later
 - Removed unnecessary shortening of MS before next conversion
   
   -        ms -= TimeUnit.HOURS.toMillis(hours);
   -        ms -= TimeUnit.MINUTES.toMillis(minutes);
 - Used  WARNING: and FATAL: instead of +++ WARNING - and +++ FATAL -
 - renamed getNiceMsTimeDate to formatMsToDaysAndTime
 - Replaced System.out by preset out
 - added warning if timebudget is to small
 - print time budfget also for listing
   
   Required two small refactorings to get nice code reused
 - ... and 1 more: https://git.openjdk.org/jcstress/compare/0b4df885...cbedff70

-------------

Changes:
  - all: https://git.openjdk.org/jcstress/pull/161/files
  - new: https://git.openjdk.org/jcstress/pull/161/files/7b68f54b..cbedff70

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jcstress&pr=161&range=07
 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=161&range=06-07

  Stats: 1673 lines in 74 files changed: 1124 ins; 437 del; 112 mod
  Patch: https://git.openjdk.org/jcstress/pull/161.diff
  Fetch: git fetch https://git.openjdk.org/jcstress.git pull/161/head:pull/161

PR: https://git.openjdk.org/jcstress/pull/161


More information about the jcstress-dev mailing list