RFR: 7903750: TimeBudget (-tb) does not fulfill its promisses [v8]
Jiří Vaněk
jvanek at openjdk.org
Mon Jun 23 08:49:47 UTC 2025
On Mon, 23 Jun 2025 08:22:32 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> Added warning, when time budget is to small, and final run will run at least two times longer.
>
> Jiří Vaněk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>
> - Removed duplicated construcion of timebudget
> - directly return new instance without intermediate variable
>
> Co-authored-by: Galder Zamarreño <galder at redhat.com>
> - Removed table like formatting for time budget warnning
> - Removed unnecesasary NPE check in getTimeBudget
>
> The NPE workaround was causing NPE to be only delayed for later
> - Removed unnecessary shortening of MS before next conversion
>
> - ms -= TimeUnit.HOURS.toMillis(hours);
> - ms -= TimeUnit.MINUTES.toMillis(minutes);
> - Used WARNING: and FATAL: instead of +++ WARNING - and +++ FATAL -
> - renamed getNiceMsTimeDate to formatMsToDaysAndTime
> - Replaced System.out by preset out
> - added warning if timebudget is to small
> - print time budfget also for listing
>
> Required two small refactorings to get nice code reused
> - ... and 1 more: https://git.openjdk.org/jcstress/compare/1d143cbd...cbedff70
hi! All my PRs rebased.
-------------
PR Comment: https://git.openjdk.org/jcstress/pull/161#issuecomment-2995524592
More information about the jcstress-dev
mailing list