RFR: 7903750: TimeBudget (-tb) does not fulfill its promisses [v4]

[Jiří Vaněk]

On Fri, 21 Mar 2025 10:32:27 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unnecessary shortening of MS before next conversion
>>   
>>   -        ms -= TimeUnit.HOURS.toMillis(hours);
>>   -        ms -= TimeUnit.MINUTES.toMillis(minutes);
>
> jcstress-core/src/main/java/org/openjdk/jcstress/infra/grading/ReportUtils.java line 308:
> 
>> 306:         long hours = TimeUnit.MILLISECONDS.toHours(ms);
>> 307:         ms -= TimeUnit.HOURS.toMillis(hours);
>> 308: 
> 
> Unnecessary

Gosh. Right yo are! I missed that completely! TY!

> jcstress-core/src/main/java/org/openjdk/jcstress/infra/grading/ReportUtils.java line 311:
> 
>> 309:         long minutes = TimeUnit.MILLISECONDS.toMinutes(ms);
>> 310:         ms -= TimeUnit.MINUTES.toMillis(minutes);
>> 311: 
> 
> Unnecessary

Gosh. Right yo are! I missed that completely! TY!

-------------

PR Review Comment: https://git.openjdk.org/jcstress/pull/161#discussion_r2007530547
PR Review Comment: https://git.openjdk.org/jcstress/pull/161#discussion_r2007530626