RFR: 7903750: TimeBudget (-tb) does not fulfill its promisses [v5]

[Jiří Vaněk]

On Fri, 21 Mar 2025 10:34:26 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unnecesasary NPE check in getTimeBudget
>>   
>>   The NPE workaround was causing NPE to be only delayed for later
>
> Changes requested by galder (no project role).

hi @galderz  !  TYVM for eyeball! I had  adjusted to all of your comments, and left few question marks.  Hope that is ok. thank you again!  (If I missed any, it was not intentional)

> jcstress-core/src/main/java/org/openjdk/jcstress/JCStress.java line 89:
> 
>> 87: 
>> 88:     private TimeBudget getTimeBudget(ConfigsWithScheduler config) {
>> 89:         if (config == null) {
> 
> By returning null you'll get an NPE when `printOn` is called in next line. If `config == null` you will get an NPE now. Seems like this change does not change anything. So, without that, I don't see a reason to wrap the TimeBudget instantiation in a private method.

Yah, right you are.  I had removed the chck.

Still I have kept the emthod extracted. It is not exactly clear from what to construct default TimeBudget. Eg, there are at last two test lists available. The existing tests, and later the expanded multiplied tests. This is based  on the second, but is easily to be swapped with first by mistake.

I would rather keep the method then duplicate the `new TimeBudget(config.configs.size(), opts.timeBudget());`

Maybe rename it to getDefaultTimeBudget ?  I omitted it as the budget is set by user xor calculated.. so it is not jsut default, but that one and only one.

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/161#issuecomment-2743321016
PR Review Comment: https://git.openjdk.org/jcstress/pull/161#discussion_r2007547387