[PATCH] Properly (.hg)ignore the JTwork and JTreport directories

[David Holmes]

Hi Gustavo,

Thanks for the detailed checking. Turns out (thanks Mikael!) that this 
was a local customization on my part - my .hgrc points to a local 
.hgignore which has:

JTwork.*/

Sorry for the noise. I'd forgotten this even existed.

David

On 3/07/2019 7:22 am, Gustavo Romero wrote:
> Hi David!
> 
> On 07/01/2019 06:21 PM, David Holmes wrote:
>> Hi Gustavo,
>>
>> On 1/07/2019 11:44 pm, Gustavo Romero wrote:
>>> Hi Jaikiran, David
>>>
>>> On 06/30/2019 10:55 PM, Jaikiran Pai wrote:
>>>>
>>>> On 01/07/19 4:00 AM, David Holmes wrote:
>>>>> On 30/06/2019 10:22 pm, Jaikiran Pai wrote:
>>>>>> Hello David,
>>>>>>
>>>>>> On 30/06/19 11:03 AM, David Holmes wrote:
>>>>>>> Hi Jaikiran,
>>>>>>>
>>>>>>> On 29/06/2019 5:16 am, Jaikiran Pai wrote:
>>>>>>>> Can I please get a review and a sponsor for this patch[1] which 
>>>>>>>> fixes
>>>>>>>> the .hgignore file to take into account the JTreport and JTwork
>>>>>>>> directories that can reside at the root of the repository.
>>>>>>>
>>>>>>> I don't see any problem with current settings. I wonder if it is hg
>>>>>>> version specific?
>>>>>>>
>>>>>> That's possible. I am on macOS (10.14.1) with mercurial version at
>>>>>> 4.3.1:
>>>>>>
>>>>>> hg --version
>>>>>> Mercurial Distributed SCM (version 4.3.1)
>>>>>> (see https://mercurial-scm.org for more information)
>>>>>>
>>>>>> I will upgrade to latest release of mercurial and see if it changes
>>>>>> anything.
>>>>>
>>>>> I'm actually downrev at 3.4.2, on Linux.
>>>>>
>>>>> David
>>>>
>>>> I upgraded to 5.0.1:
>>>>
>>>> hg --version
>>>> Mercurial Distributed SCM (version 5.0.1)
>>>> (see https://mercurial-scm.org for more information)
>>>>
>>>> and haven't seen a difference. The JTwork and JTreport at the root of
>>>> the repos still aren't ignored.
>>>
>>> Jaikiran, thanks for enhancing the .hgignore.
>>>
>>> I do would like to extend the reachout of .hgignore for JT*, 
>>> specially for the
>>> root dir, because when fixing some jtreg tests, for instance, it's 
>>> common one to
>>> trigger jtreg from the root for specific tests being fixed and so a 
>>> JTwork and
>>> JTreport will be created. The currently ignore rules won't cover that 
>>> so I
>>> think your enhancement is welcome.
>>
>> What version of hg are you using?
> 
> So, I tested hg 4.5.3 from distro (Ubuntu/Bionic), hg 4.3.1 (upstream), 
> hg 3.4.2
> (upstream), and hg 5.0.1 (upstream), and I got same results, the JT* 
> dirs in
> the root dir are not ignored:
> 
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg --version
> Mercurial Distributed SCM (version 5.0.1)
> (see https://mercurial-scm.org for more information)
> 
> Copyright (C) 2005-2019 Matt Mackall and others
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg status | fgrep JT
> ? JTreport/blah
> ? JTwork/blah
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg status -i | fgrep JT
> gromero at gromero7:~/hg/jdk/jdk$
> 
> -- 
> 
> gromero at gromero7:~/hg/jdk/jdk$ hg --version
> Mercurial Distributed SCM (version 4.5.3)
> (see https://mercurial-scm.org for more information)
> 
> Copyright (C) 2005-2018 Matt Mackall and others
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> gromero at gromero7:~/hg/jdk/jdk$ hg status | fgrep JT
> ? JTreport/blah
> ? JTwork/blah
> gromero at gromero7:~/hg/jdk/jdk$ hg status -i | fgrep JT
> gromero at gromero7:~/hg/jdk/jdk$
> 
> -- 
> 
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg --version
> Mercurial Distributed SCM (version 4.3.1)
> (see https://mercurial-scm.org for more information)
> 
> Copyright (C) 2005-2017 Matt Mackall and others
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg status | fgrep JT
> ? JTreport/blah
> ? JTwork/blah
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg status -i | fgrep JT
> gromero at gromero7:~/hg/jdk/jdk$
> 
> -- 
> 
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg --version
> Mercurial Distributed SCM (version 3.4.2)
> (see http://mercurial.selenic.com for more information)
> 
> Copyright (C) 2005-2015 Matt Mackall and others
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg status | fgrep JT
> ? JTreport/blah
> ? JTwork/blah
> gromero at gromero7:~/hg/jdk/jdk$ ~/hg/hg/hg status -i | fgrep JT
> gromero at gromero7:~/hg/jdk/jdk$
> 
> 
>> I don't mind making changes but if hg is changing the way it processes 
>> this file across different versions then we need to be sure that this 
>> is working for all of them.
> 
> Yeah, we need to sort it out first. I'm wondering if there is any hook 
> or .hgrc
> locally affecting it. On the other hand I don't see any rule currently 
> in the
> .hgignore that would take care of ignoring the JT* in root, only in 
> .gitignore
> I see rules for that. Any thoughts?
> 
> 
>> I'm also not sure jdk-dev is the right mailing list here as there may 
>> be few people actively watching for patches here.
> 
> Yes, I suggested build-dev ML to Jaikiran based on the latest reviews for
> changes in .hgignore, but not really sure which one is the best. I just 
> posted
> some diffs as examples previously. Anyway, I believe we need to 
> understand why
> we don't get JT* ignored and you get it fine. Please let me know if can
> provide more information to help on that.
> 
> 
> Thank you.
> 
> Best regards,
> Gustavo