RFR: 8227009 : JDK 13 L10n resource files update - msg drop 10
li.jiang at oracle.com
li.jiang at oracle.com
Wed Jul 10 08:26:08 UTC 2019
Thank you, the msg drop pushed. I will file two bugs to track the
copyright header and copyright year issues.
-Leo
On 7/9/19 9:09 PM, naoto.sato at oracle.com wrote:
> Looks good to me. If you are not going address the first two issues with
> this changeset, please file JIRA issues for each.
>
> Naoto
>
> On 7/8/19 8:36 PM, li.jiang at oracle.com wrote:
>> Hi Naoto,
>>
>> Got the fix and updated the webrev:
>>
>> http://cr.openjdk.java.net/~ljiang/8227009/webrev.01/read/
>>
>> Would you help to review the change?
>>
>> Thanks,
>> Leo
>>
>>
>> On 7/4/19 1:36 AM, naoto.sato at oracle.com wrote:
>>> Hi Leo,
>>>
>>> Here are my comments:
>>>
>>> - l10n files for javadoc have copyright year for 2018.
>>>
>>> - javap l10n files have no copyright headers.
>>>
>>> -
>>> src/jdk.rmic/share/classes/sun/tools/javac/resources/javac_ja.properties:
>>> Not sure for Chinese but at least for Japanese, this translation
>>> reads incorrect. It seems that it translates "preview feature" in a
>>> wrong way, and ended up very cryptic translation.
>>>
>>> Naoto
>>>
>>>
>>> On 7/1/19 2:15 AM, li.jiang at oracle.com wrote:
>>>> Hi,
>>>>
>>>> Pls review the update for JDK 13 L10N resource files update message
>>>> drop 10. This is the first msg drop for JDK 13. Any changes after
>>>> the kick-off date (June 22th), would be handled in the msg drop 20.
>>>> If you found your changes should be in msg drop 10 but not, pls let
>>>> me know.
>>>>
>>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8227009
>>>> Webrev: http://cr.openjdk.java.net/~ljiang/8227009/webrev/read/
>>>>
>>>> Thanks,
>>>> Leo
More information about the jdk-dev
mailing list