Is webrev generation still relevant?

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Jan 23 14:56:55 UTC 2024


I hear you all, loud and clear, that webrev is still widely used and 
popular. Rest assured, I will not try to remove any useful tooling under 
your feet. :-)

On 2024-01-19 02:47, David Holmes wrote:

> On 18/01/2024 7:04 pm, Magnus Ihse Bursie wrote:
>> So, my second question is:
>>
>> * Should we keep the idea of a bot that generates diff pages, but 
>> instead of mimicking the old webrev script, tailor it to cover up for 
>> those use cases where GitHub falls short?
>
> That depends on exactly what you mean? The webrev frames view is its 
> most valuable aspect to me.

What I meant was that the Skara webrev implementation tried to achieve a 
near-perfect copy of the old ksh webrev, and since that point it has not 
received any additional improvements.

I was thinking that maybe it would be possible to modernize and 
streamline the webrev interface to facilitate using it where it really 
shines, and hiding or removing some of the clutter. But I guess 
continuing that though would take me to a minefield. :-)

/Magnus



More information about the jdk-dev mailing list