Is webrev generation still relevant?
Mario Torre
neugens at redhat.com
Tue Jan 23 15:08:41 UTC 2024
On Tue, Jan 23, 2024 at 3:57 PM Magnus Ihse Bursie
<magnus.ihse.bursie at oracle.com> wrote:
>
> I hear you all, loud and clear, that webrev is still widely used and
> popular. Rest assured, I will not try to remove any useful tooling under
> your feet. :-)
>
> On 2024-01-19 02:47, David Holmes wrote:
>
> > On 18/01/2024 7:04 pm, Magnus Ihse Bursie wrote:
> >> So, my second question is:
> >>
> >> * Should we keep the idea of a bot that generates diff pages, but
> >> instead of mimicking the old webrev script, tailor it to cover up for
> >> those use cases where GitHub falls short?
> >
> > That depends on exactly what you mean? The webrev frames view is its
> > most valuable aspect to me.
>
> What I meant was that the Skara webrev implementation tried to achieve a
> near-perfect copy of the old ksh webrev, and since that point it has not
> received any additional improvements.
>
> I was thinking that maybe it would be possible to modernize and
> streamline the webrev interface to facilitate using it where it really
> shines, and hiding or removing some of the clutter. But I guess
> continuing that though would take me to a minefield. :-)
If GitHub was actually open source, one could propose the webrew
interface for their tool for the world to benefit :)
Cheers,
Mario
--
Mario Torre
Manager, Software Engineering, Red Hat OpenJDK, Java Champion
https://keybase.io/neugens
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
Mastodon: https://mastodon.social/@MarioTorre
Red Hat GmbH, Registered seat: Werner von Siemens Ring 12, D-85630
Grasbrunn, Germany
Commercial register: Amtsgericht Muenchen/Munich, HRB 153243,
Managing Directors: Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross
More information about the jdk-dev
mailing list