Proposal: Require re-review before integration if the PR is modified
Severin Gehwolf
sgehwolf at redhat.com
Wed Jun 19 14:31:43 UTC 2024
On Wed, 2024-06-19 at 15:00 +0100, Andrew Haley wrote:
> Maybe this policy will result in some otherwise unnecessary
> re-reviewing. But as long as it's only a single reviewer to do a final
> pass, rather than a tick from everyone who has approved, I agree with
> this policy.
I like this idea of a single reviewer only (not all of them) needing to
approve the final version.
FWIW, I tend to merge latest master before integrating so as to reduce
chance of breakages caused by rebases at integration time. This process
change seems to me then needing to chase up all reviewers again to
approve the final version.
Thanks,
Severin
More information about the jdk-dev
mailing list