Proposal: Require re-review before integration if the PR is modified

[Thomas Stüfe]

On Wed, Jun 19, 2024 at 4:32 PM Severin Gehwolf <sgehwolf at redhat.com> wrote:

> On Wed, 2024-06-19 at 15:00 +0100, Andrew Haley wrote:
> > Maybe this policy will result in some otherwise unnecessary
> > re-reviewing. But as long as it's only a single reviewer to do a final
> > pass, rather than a tick from everyone who has approved, I agree with
> > this policy.
>
> I like this idea of a single reviewer only (not all of them) needing to
> approve the final version.
>

+1 for single reviewer only. I think that is a pragmatic compromise.


>
> FWIW, I tend to merge latest master before integrating so as to reduce
> chance of breakages caused by rebases at integration time. This process
> change seems to me then needing to chase up all reviewers again to
> approve the final version.
>
> Thanks,
> Severin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-dev/attachments/20240619/61f15dd0/attachment.htm>