Improving OpenJDK for FreeBSD

Thomas Stüfe thomas.stuefe at gmail.com
Fri Feb 14 07:31:57 UTC 2025


Hi Harald,

In addition to what David wrote:

- PPC changes: we already deal with AIX and Linux, and adding BSD is
getting a bit #ifdef heavy. I wonder whether we should factor certain
things out into (aix|bsd|linux)_ppc.cpp. For example, all of these os/cpu
combinations use the same register set, but the ucontext is different for
every one of them, so a utility function like `get_gpr_from_context(const
ucontext_t* c, int num)` would help. Ultimately, that is up to Martin as
ppc lead (I set him on cc).

- the bigger issue to me is the amount of large ifdef sections added to
os/bsd and bsd/<arch> : I think its time to separate MacOS from BSD and
make both first-class OSes. The amount of duplicate coding would be
outweighed by clearer code. Up for discussion, of course; that is just my
gut feeling right now.

Cheers, Thomas




On Thu, Feb 13, 2025 at 12:49 PM Harald Eilertsen <harald+jdklists at volse.no>
wrote:

> On Wed, Feb 05, 2025 at 11:25:51AM +1000, David Holmes wrote:
> > Hi Harald,
> >
> > Can you create a PR against mainline so that we can see the scope of the
> > changes and how they have been implemented?
>
> Here you go:
> https://github.com/openjdk/jdk/pull/23611
>
> As mentioned in the notes for the PR, this is mainly ment to get your
> feedback and as a draft to assess the scope, and to be a base for
> discussing how (and if) to proceed with the port.
>
> Looking forward to your thoughts and feedback!
>
> Harald Eilertsen
> --
> Eilertsens Kodeknekkeri
> https://kodeknekkeriet.net
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-dev/attachments/20250214/2d58672e/attachment.htm>


More information about the jdk-dev mailing list