[11u] RFR: 8222299: [TESTBUG] move hotspot container tests to hotspot/containers
Aleksey Shipilev
shade at redhat.com
Mon Aug 19 17:32:56 UTC 2019
On 8/19/19 5:20 PM, Severin Gehwolf wrote:
> JDK-8221894: http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-August/001684.html
> JDK-8219997: http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-August/001681.html
>
> I'm not sure what you mean (perhaps even a moot point now?). 8219997
> isn't (yet) in OpenJDK 11u, thus JDK-8222299, could not possibly move
> the files somewhere else. That was true for webrev 02. webrev 03
> (latest) changed that by depending on JDK-8219997 backport. Perhaps I'm
> missing something?
I understand this is the order the changes went in jdk/jdk:
8219997 -- adds 2 new files to runtime/containers/docker
8222299 -- moves all files from runtime/containers/docker to containers/docker
Stands to reason that if you do 8219997 first, you would get files in their old locations, and then
8222299 moves them to the new ones. Then, 11u history and jdk/jdk history would agree: in both
histories, 2 new files would be added by 8219997.
Your current webrev says:
test/hotspot/jtreg/containers/docker/JfrReporter.java (was
test/hotspot/jtreg/runtime/containers/docker/JfrReporter.java)
test/hotspot/jtreg/containers/docker/TestJFREvents.java (was
test/hotspot/jtreg/runtime/containers/docker/TestJFREvents.java)
...so the 8219997 changeset *is* in your patch queue, it just does not show up in webrev file
history for JfrReporter.java and TestJFREvents.java? That is what confused me.
--
Thanks,
-Aleksey
More information about the jdk-updates-dev
mailing list