[11u] RFR: Backport 8216354: Syntax error in toolchain_windows.m4

[Simon Tooke]

On 8/29/2019 5:10 AM, Langer, Christoph wrote:
> Hi Simon,
>
> I just approved this tiny patch for jdk11u.
>
> As for an updated review: First of all, the webrev URL has changed: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8216354-11u/
>
> This patch was carved out of JDK-8215445.
> However, in there, the modified line reads:
> if test -z "$(ls -d $with_ucrt_dll_dir/*.dll 2> /dev/null)"; then
> instead of:
> if test -z "$(ls -d "$with_ucrt_dll_dir/"*.dll 2> /dev/null)"; then
>
> (you have additional quotes around $with_ucrt_dll_dir/). Are you sure this is correct? Why can't we use the upstream version?

I've reviewed (and tried) the patch and determined my patch (which was
proposed in the original bug by the original reporter) is the correct
one, and the upstream version in fact doesn't work.  As the bug is
marked "won't fix" I haven't tried to get it reopened in jdk 13/14.

Because of this, I'm not actually sure this qualifies as a backport. 
Unfortunately, the original reporter is only known as "Webbug Group".

As a result of this, I'm not sure what to put for reviewer, author,
etc.  Do you (or others) have any recommendations on what's appropriate?

Thanks,

-Simon


> Further, if you eventually submit the patch, you need to add the right commit message, reviewer etc. to please jcheck. You should probably also increment the copyright year.
>
> Thanks
> Christoph
>
>> -----Original Message-----
>> From: Langer, Christoph
>> Sent: Sonntag, 30. Juni 2019 08:23
>> To: Simon Tooke <stooke at redhat.com>; jdk-updates-
>> dev at openjdk.java.net
>> Subject: RE: [11u] RFR: Backport 8216354: Syntax error in
>> toolchain_windows.m4
>>
>> Hi Simon,
>>
>> the 11u fix looks good to me.
>>
>> Thanks
>> Christoph
>>
>>> -----Original Message-----
>>> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
>>> Behalf Of Simon Tooke
>>> Sent: Freitag, 28. Juni 2019 22:45
>>> To: jdk-updates-dev at openjdk.java.net
>>> Subject: [11u] RFR: Backport 8216354: Syntax error in
>> toolchain_windows.m4
>>> This is a request to backport the changes required to fix 8216354.  It's
>>> been sitting on my TODO pile for too long.
>>>
>>> The actual 8216354 was fixed as part of a later commit, but I have
>>> webrevs to just backport the relevant change (one line) to jdk8u and
>>> 11u.  I'll be sending out this identical RFR on both lists as separate
>>> threads.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8216354
>>>
>>> Webrev (jdk8u): http://cr.openjdk.java.net/~stooke/webrevs/jdk-
>> 8216354-
>>> jdk8/
>>>
>>> Webrev (jdk11u):
>>> http://cr.openjdk.java.net/~stooke/webrevs/jdk-8216354-jdk11/
>>>
>>> Thank you for your time,
>>>
>>> -Simon.
>>>