[11u] RFR 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

[Doerr, Martin]

Hi Götz,

Ok, replacing '$' by '.' in the new make file makes sense.
Looks good.

Best regards,
Martin


> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Lindenmaier, Goetz
> Sent: Montag, 16. Dezember 2019 09:43
> To: jdk-updates-dev at openjdk.java.net
> Subject: [11u] RFR 8213348:
> jdk.internal.vm.compiler.management service providers missing in module
> descriptor
> 
> Hi,
> 
> The patch applied clean, but I had to do an adaption
> to get the build working.
> http://cr.openjdk.java.net/~goetz/wr19/8213348-service_provider_missing-
> jdk11/01/
> 
> The new makefile generates module-info.java files.
> It adds an export for the inner class GraalServices$JMXService.
> In the module-info, the $ must be replaced by ..
> 
> In 14, the inner class GraalServices$JMXService was
> transferred into a real class, thus the problem does not show there.
> 
> Fix:
> 
> --- a/make/gensrc/Gensrc-jdk.internal.vm.compiler.management.gmk  Thu
> Nov 08 15:19:14 2018 -0800
> +++ b/make/gensrc/Gensrc-jdk.internal.vm.compiler.management.gmk
> Tue Dec 10 19:16:43 2019 +0100
> @@ -74,7 +74,7 @@
>                  p=""; \
>                  impl=""; \
>                  for i in $$($(GREP) '^' * | $(SORT) -t ':' -k 2 | $(SED) 's/:.*//'); do \
> -                   c=$$($(CAT) $$i | $(TR) -d '\n\r'); \
> +                  c=$$($(CAT) $$i | $(TR) -d '\n\r' | $(TR) '$$' '.' ); \
>                    if test x$$p != x$$c; then \
>                  if test x$$p != x; then \
>                        $(ECHO) "    ;" >> $@; \
> 
> Best regards,
>   Goetz.