[DMARC FAILURE] [11u] RFR 8208601: Introduce native oop barriers in C2 for OopHandle
Langer, Christoph
christoph.langer at sap.com
Wed Sep 4 13:53:01 UTC 2019
Hi Jaroslav,
when resolving barrierSetC2.cpp, you need to take into account that JDK-8218879 "Keep track of memory accesses originated from Unsafe" was already backported to jdk11u-dev.
So I believe you need to add the variable unsafe to the call to kit->make_load in lines 118/119 (new). See: http://hg.openjdk.java.net/jdk/jdk/rev/e002408eb0c0
I'll add the patches for JDK-8208582, JDK-8208601 (with the added unsafe) and JDK-8210158 to our test queue and let you know the results. Please don't push until then.
Thanks & Best regards
Christoph
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Jaroslav Bachorík
> Sent: Mittwoch, 4. September 2019 12:15
> To: jdk-updates-dev at openjdk.java.net
> Subject: [DMARC FAILURE] [11u] RFR 8208601: Introduce native oop barriers
> in C2 for OopHandle
>
> Hi,
>
> Original bug:
> https://bugs.openjdk.java.net/browse/JDK-8208601
> https://hg.openjdk.java.net/jdk/jdk12/rev/0c7040d1d1ca
>
> Backport requires JDK-8208582
> <https://bugs.openjdk.java.net/browse/JDK-8208582>.
> The patch does not apply cleanly due to minor differences in the context of
> barrierSetC2.cpp
> <http://cr.openjdk.java.net/~jbachorik/8208601/barrierSetC2.cpp.rej> but
> manual resolution is extremely simple.
>
> Rej file: http://cr.openjdk.java.net/~jbachorik/8208601/barrierSetC2.cpp.rej
>
> 11u webrev:
> http://cr.openjdk.java.net/~jbachorik/8208601/
>
> Testing:
> - tier1
> - tier2
>
> Thanks,
>
> -JB-
More information about the jdk-updates-dev
mailing list