[11u] RFR 8251487: Shenandoah: missing detail timing tracking for final mark cleaning phase

Roman Kennke rkennke at redhat.com
Tue Aug 18 13:39:18 UTC 2020


Hi Zhengyu,


> > - the order of placement of _phase and its initializer don't match.
> > Some compilers are not going to like this.
> > - the indentation of _phase wrt the other fields doesn't match
> > - Alignment don't match here:
> > 
> > +  ParallelCleaningTask(ShenandoahPhaseTimings::Phase phase,
> > BoolObjectClosure* is_alive, bool process_strings,
> > +    bool process_symbols, uint num_workers, bool
> > unloading_occurred);
> 
> Updated: 
> http://cr.openjdk.java.net/~zgu/JDK-8251487/webrev.01/index.html
> 
> Okay now?

Yes, looks good! Thank you!

Roman




More information about the jdk-updates-dev mailing list