[11u] RFR 8251487: Shenandoah: missing detail timing tracking for final mark cleaning phase

Zhengyu Gu zgu at redhat.com
Tue Aug 18 14:26:11 UTC 2020



On 8/18/20 9:39 AM, Roman Kennke wrote:
> Hi Zhengyu,
> 
> 
>>> - the order of placement of _phase and its initializer don't match.
>>> Some compilers are not going to like this.
>>> - the indentation of _phase wrt the other fields doesn't match
>>> - Alignment don't match here:
>>>
>>> +  ParallelCleaningTask(ShenandoahPhaseTimings::Phase phase,
>>> BoolObjectClosure* is_alive, bool process_strings,
>>> +    bool process_symbols, uint num_workers, bool
>>> unloading_occurred);
>>
>> Updated:
>> http://cr.openjdk.java.net/~zgu/JDK-8251487/webrev.01/index.html
>>
>> Okay now?
> 
> Yes, looks good! Thank you!

Thanks, Roman.

-Zhengyu
> 
> Roman
> 
> 



More information about the jdk-updates-dev mailing list