[11u] RFR: 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

[Langer, Christoph]

Hi Jaikiran,

I've ran your patches through our testing now. It turns out that 8218268 needs a little modification for 11u. The call Path.of(url.toURI()) needs to be converted to Paths.get(url.toURI()) because of the requirement of JDK11 to be buildable with a bootstrap OpenJDK of version 10. com.sun.tools.javac.file.FSInfo is compiled with the bootstrap JDK and JDK 10 does not yet have the Path.of methods.

So request to the Reviewers: May I please get a review for: http://cr.openjdk.java.net/~clanger/webrevs/8218268.11u/ ?

Thanks
Christoph



> -----Original Message-----
> From: Jaikiran Pai <jai.forums2013 at gmail.com>
> Sent: Montag, 30. Dezember 2019 15:19
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR: 8218268: Javac treats Manifest Class-Path entries as
> Paths instead of URLs
> 
> Hello Christoph,
> 
> On 30/12/19 4:12 PM, Langer, Christoph wrote:
> > Hi Jaikiran,
> >
> > I guess it's holiday season so you ran into a little delay.
> >
> > Your request involves two bugfixes, one is JDK-8232170 and the other is
> JDK-8218268. They should be backported separately. From looking at their
> description, I guess they are viable candidates for a backport. They alter the
> behavior of javac a bit - but I'd assume only in the sense of fixing bugs ��.
> >
> > Since both patches apply cleanly, I have added them to our build&test
> system. We should have results on whether there are regressions by
> tomorrow.
> 
> Thank you very much for doing that.
> 
> 
> >
> > Can you please add a fix request comment&label to JDK-8232170 as well? In
> case everything goes fine I'll approve and sponsor for you.
> 
> I've now updated that JBS issue to include a backport RFR comment as
> well as added the jdk11u-fix-request label. Thanks again for sponsoring
> this :)
> 
> -Jaikiran
>