[13u] RFR 8238284: [macos] Zero VM build fails due to an obvious typo

Yuri Nesterenko yan at azul.com
Thu Jul 2 09:38:05 UTC 2020


OK, looks good to me.

--yan

On 30.06.2020 16:00, Vladimir Kempik wrote:
> Hello
> Please review this backport of JDK-8238284 to jdk13u
> 
> The patch didn’t apply cleanly. Original 8238284 fixed two issues in jdk15:
> JDK-8237437 - since jdk14
> JDK-8165929 - since jdk11
> 
> Jdk13 only has 8165929 so only part of original fix needs to be backported to jdk13, that part applies cleanly.
> 
> This is part2 out of 3 fixes needed to fix zero vm on macos.
> 
> Fix has also part for linux but it wasn’t affected in my testing.
> 
> Risks are low because the patch just adds const keyword to some vars for zerovm
> 
> The bug: https://bugs.openjdk.java.net/browse/JDK-8238284
> The webrev: http://cr.openjdk.java.net/~vkempik/8238284/webrev.13u.00/
> Original review https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-January/040681.html
> Other two mentioned bugs: https://bugs.openjdk.java.net/browse/JDK-8234737 ,  https://bugs.openjdk.java.net/browse/JDK-8165929
> 
> Thanks, Vladimir
> 



More information about the jdk-updates-dev mailing list