[11u] RFR: 8235563: [TESTBUG] appcds/CommandLineFlagComboNegative.java does not handle archive mapping failure

[Jiangli Zhou]

Hi Christoph,

The modified backport looks good to me. The the partial change from
http://hg.openjdk.java.net/jdk/jdk/rev/e34379f2a1c8
(https://bugs.openjdk.java.net/browse/JDK-8204591) looks okay. It's
for testing the obsolete UseAppCDS option and is not critical. The
diff is small enough and we can easily resolve any potential conflicts
in the future (if necessary).

Best regards,
Jiangli


On Fri, Mar 13, 2020 at 9:16 AM Langer, Christoph
<christoph.langer at sap.com> wrote:
>
> Hi,
>
> I guess this is the last review for a patch from the Oracle parity list for 11.0.7 that will make it into the release. It's a test only change.
>
> The patch itself applies cleanly but it would result in test failures. I had to include a part from another change: http://hg.openjdk.java.net/jdk/jdk/rev/e34379f2a1c8 (https://bugs.openjdk.java.net/browse/JDK-8204591). That part would remove the test execution for the disabled option -XX:+UseAppCDS, which doesn't fail as expected by the new logic..
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8235563
> Original change: https://hg.openjdk.java.net/jdk/jdk/rev/6b8a675f35e1
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235563.11u/
>
> Please review.
>
> Thanks
> Christoph
>