[11u] RFR: 8235563: [TESTBUG] appcds/CommandLineFlagComboNegative.java does not handle archive mapping failure

[Calvin Cheung]

On 3/13/20 10:10 AM, Langer, Christoph wrote:
> Hi Calvin,
>
>>> I guess this is the last review for a patch from the Oracle parity list for 11.0.7
>> that will make it into the release. It's a test only change.
>>> The patch itself applies cleanly but it would result in test failures. I had to
>> include a part from another change:
>> http://hg.openjdk.java.net/jdk/jdk/rev/e34379f2a1c8
>> (https://bugs.openjdk.java.net/browse/JDK-8204591). That part would
>> remove the test execution for the disabled option -XX:+UseAppCDS, which
>> doesn't fail as expected by the new logic..
>>
>> The removed lines in your webrev was added for fixing
>> https://bugs.openjdk.java.net/browse/JDK-8204563.
>>
>> Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/50469fb301c4
>>
>> I guess if you want to backport the fix for this bug as is, you'd need
>> to backport JDK-8204563 as well.
> JDK-8204563 is part of OpenJDK 11u already.
Ok. I haven't been following OpenJDK 11u closely.
>
> The problem is that the fix of JDK-8235563 adds an "assertAbnormalExit".  But -XX:+UseAppCDS won't exit abnormally. It'll return cleanly with returncode 0, always using "-XX:+UseAppCDS ".

Your patch looks good.

thanks,

Calvin

>
> Best regards
> Christoph
>