[11u] RFR (XS) 8265718: Build failure after JDK-8258414 11u backport

[Thomas Stüfe]

All good and trivial. Ship it.

Sorry for stating the obvious, do you build with pch?

On Thu, Apr 22, 2021 at 9:48 AM Aleksey Shipilev <shade at redhat.com> wrote:

> On 4/22/21 9:45 AM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > Thomas is right, the patch looks good but is not.
> > I compiled on linuxx86_64 dbg/fastdbg/product with
> >
> > diff --git
> a/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
> b/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
> > ---
> a/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
> > +++
> b/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
> > @@ -24,6 +24,7 @@
> >
> >   #include "precompiled.hpp"
> >   #include "jfr/jfrEvents.hpp"
> > +#include "jfr/jni/jfrJavaSupport.hpp"
> >   #include "jfr/leakprofiler/chains/edgeStore.hpp"
> >   #include "jfr/leakprofiler/chains/objectSampleMarker.hpp"
> >   #include "jfr/leakprofiler/checkpoint/objectSampleCheckpoint.hpp"
> > @@ -37,6 +38,7 @@
> >   #include "jfr/recorder/stacktrace/jfrStackTraceRepository.hpp"
> >   #include "jfr/utilities/jfrHashtable.hpp"
> >   #include "jfr/utilities/jfrTypes.hpp"
> > +#include "runtime/interfaceSupport.inline.hpp"
> >   #include "runtime/safepoint.hpp"
> >   #include "runtime/thread.hpp"
> >   #include "utilities/growableArray.hpp"
> >
> > successfully.
> > The code uses ThreadInVMfromNative.
> >
> > Please add the interfaceSupport include and consider it reviewed.
> Added!
>
> diff -r 31224d74aa23
> src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
> ---
> a/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
> Thu Sep 05 12:39:48
> 2019 +0200
> +++
> b/src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
> Thu Apr 22 09:44:39
> 2021 +0200
> @@ -25,4 +25,5 @@
>   #include "precompiled.hpp"
>   #include "jfr/jfrEvents.hpp"
> +#include "jfr/jni/jfrJavaSupport.hpp"
>   #include "jfr/leakprofiler/chains/edgeStore.hpp"
>   #include "jfr/leakprofiler/chains/objectSampleMarker.hpp"
> @@ -38,4 +39,5 @@
>   #include "jfr/utilities/jfrHashtable.hpp"
>   #include "jfr/utilities/jfrTypes.hpp"
> +#include "runtime/interfaceSupport.inline.hpp"
>   #include "runtime/safepoint.hpp"
>   #include "runtime/thread.hpp"
>
> I wonder why it is not failing for me without a second include... Anyways.
>
> --
> Thanks,
> -Aleksey
>
>