[jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support

[Paul Hohensee]

On Tue, 10 Aug 2021 21:43:47 GMT, Reka Kovacs <github.com+25946952+rnkovacs at openjdk.org> wrote:

> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2.
> 
> Changes since then:
> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately.
> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added.
> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added.
> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added.
> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build.
> - Various small merge conflict resolutions.
> 
> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit.
> 
> Please let me know how I can make the review process easier / faster.

Copy-paste errors are one of the problems that can occur with a giant squashed backport such as this one. It's difficult to review because it's a lot of code and there's no way to tell which code belongs to which JBS issue, and there's no way to triage the almost inevitable problems that will occur with such a large patch. I'd prefer separate per-JBS-issue backports, such as Vladimir's [#215](https://github.com/openjdk/jdk11u-dev/pull/215).

I ordered, by resolution date, the parents of the above JBS issue merged with the ones from [#2](https://github.com/openjdk/jdk11u/pull/2).

https://bugs.openjdk.java.net/browse/JDK-8248403
https://bugs.openjdk.java.net/browse/JDK-8248414
https://bugs.openjdk.java.net/browse/JDK-8248671
https://bugs.openjdk.java.net/browse/JDK-8248666
https://bugs.openjdk.java.net/browse/JDK-8248668
https://bugs.openjdk.java.net/browse/JDK-8248657
https://bugs.openjdk.java.net/browse/JDK-8248682
https://bugs.openjdk.java.net/browse/JDK-8250810
https://bugs.openjdk.java.net/browse/JDK-8250824
https://bugs.openjdk.java.net/browse/JDK-8248816
https://bugs.openjdk.java.net/browse/JDK-8254072
https://bugs.openjdk.java.net/browse/JDK-8254827
https://bugs.openjdk.java.net/browse/JDK-8261072
https://bugs.openjdk.java.net/browse/JDK-8263136
https://bugs.openjdk.java.net/browse/JDK-8265756
https://bugs.openjdk.java.net/browse/JDK-8252114
https://bugs.openjdk.java.net/browse/JDK-8272181

I didn't include the umbrella issue https://bugs.openjdk.java.net/browse/JDK-8248238.

I've posted a backport PR for [JDK-8248403](https://bugs.openjdk.java.net/browse/JDK-8248403) at [#246](https://github.com/openjdk/jdk11u-dev/pull/246).

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/222