[jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls

[Aleksey Shipilev]

On Mon, 23 Aug 2021 14:00:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK.
> 
> Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test.

I have questions :)

src/hotspot/share/jvmci/jvmciRuntime.cpp line 455:

> 453:   }
> 454: 
> 455:   inline void do_object() {       _jca->push_oop(next_object()); }

Excess whitespace before `_jca`.

src/hotspot/share/jvmci/jvmciRuntime.cpp line 470:

> 468:   inline void do_array(int begin, int end)  { if (!is_return_type()) do_object(); }
> 469: 
> 470:   inline void do_void()                     { }

Excess whitespace before `{ }`.

src/hotspot/share/jvmci/jvmciRuntime.cpp line 513:

> 511:         return value->f;
> 512:       case T_DOUBLE:
> 513:         return value->d;

The original commit uses `value->i` and `value->j` here. Of course, `value->f` and `value->d` look more correct, but do you understand why this difference?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/279