[jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls

Severin Gehwolf sgehwolf at openjdk.java.net
Tue Aug 24 12:34:24 UTC 2021


On Mon, 23 Aug 2021 14:31:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I'm pretty sure the GHA tier1 failure of `gc/stress/gcold/TestGCOldWithCMS.java` on Linux x86 is unrelated as this is an JVMCI only change.
>
>> I'm pretty sure the GHA tier1 failure of `gc/stress/gcold/TestGCOldWithCMS.java` on Linux x86 is unrelated as this is an JVMCI only change.
> 
> Yes, it looks like another instance of [JDK-8272195](https://bugs.openjdk.java.net/browse/JDK-8272195).

@shipilev I've updated the patch to be similar to the mainline version now. Changes include:

- Get rid of unused `is_static` boolean in `ArgumentPusher`
- Get rid of unused `expectedType` in `nextArg()`
- Use local variable `return_type` over calling `jap.get_ret_type()` repeatedly.
- Use the same fall-through case for `T_DOUBLE/T_LONG` (`value->j`) and `T_INT/T_FLOAT` (`value->i`), which matches mainline.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/279


More information about the jdk-updates-dev mailing list