[11u] RFR: 8261209: isStandalone property: remove dependency on pretty-print

Hohensee, Paul hohensee at amazon.com
Thu Mar 11 18:02:20 UTC 2021


Hi, Goetz,

Looking at the latest 11u version of PrettyPrintTest.java (pushed 6 days ago), it does contain the modified parts.

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of "Doerr, Martin" <martin.doerr at sap.com>
Date: Thursday, March 11, 2021 at 8:51 AM
To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Cc: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>, "Langer, Christoph" <christoph.langer at sap.com>
Subject: [11u] RFR: 8261209: isStandalone property: remove dependency on pretty-print

Hi,

JDK-8261209 is backported to 11.0.11-oracle. I'd like to backport it for parity.
The actual fix is trivial, but the remainder of the original patch doesn't apply to 11u.

So I suggest the following:
- Only take the real fix which is in ToXMLStream.java (LastModified timestamp doesn't exist in 11u).
- Skip module-info.java: The modified comments don't exist in 11u.
- Skip PrettyPrintTest.java: The modified parts of the test don't exist in 11u.

The existing tests are still passing with the fix.

Original bug:
https://bugs.openjdk.java.net/browse/JDK-8261209

Original change:
https://github.com/openjdk/jdk/commit/7c565f8b

11u backport:
http://cr.openjdk.java.net/~mdoerr/8261209_xml_11u/webrev.00/

Please review.

Best regards,
Martin




More information about the jdk-updates-dev mailing list