RFR [jdk11]: 8232084: HotSpot build failed with GCC 9.2.1

Yasumasa Suenaga suenaga at oss.nttdata.com
Wed May 12 09:01:55 UTC 2021


Hi Matthias,

On 2021/05/12 16:47, Baesken, Matthias wrote:
> Hello,  I  please review the backport of  8232084  to jdk11 .
> 
> This is needed to make  jdk11  buildable with gcc-9   (tested on linux  x86_64) .
> 
> Changes in the jdk11 backport  compared to jdk/jdk :
> 
> hotspot/cpu/x86/macroAssembler_x86.hpp  change is not needed in jdk11
> 
> src/hotspot/share/utilities/compilerWarnings_gcc.hpp   does not exist in jdk11 so the  compilerWarnings_gcc.hpp change  goes to  compilerWarnings.hpp
> 
> additionally to be able to build with gcc-9   in make/autoconf/flags-cflags.m4  -Wno-stringop-truncation  has to be set (issues in jvmti test coding and liblcms )

I heard that we should disable warnings as narrow as possible in the review. (I forget what ticket it is about)
However, to disable warnings in third party libraries like liblcms, we can disable them at the makefile for them.
In case of liblcms, it is prefer to disable stringop-truncation at Awt2dLibraries.gmk .


Thanks,

Yasumasa


> (tested to build jdk11u-dev on linux x86_64  with gcc-4.8 and gcc-7 this still works too )
> 
> Bug/webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8232084 <https://bugs.openjdk.java.net/browse/JDK-8232084>
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8232084.0_jdk11/ <http://cr.openjdk.java.net/~mbaesken/webrevs/8232084.0_jdk11/>
> 
> original  change :
> 
> https://hg.openjdk.java.net/jdk/jdk/rev/9f5b92d5a1b2 <https://hg.openjdk.java.net/jdk/jdk/rev/9f5b92d5a1b2>
> 
> Thanks, Matthias
> 


More information about the jdk-updates-dev mailing list