RFR [jdk11]: 8232084: HotSpot build failed with GCC 9.2.1

[Yasumasa Suenaga]

Hi Matthias,

On 2021/05/12 20:02, Baesken, Matthias wrote:
> 
>> However, to disable warnings in third party libraries like liblcms, we can disable them at the makefile for them.
>> In case of liblcms, it is prefer to disable stringop-truncation at Awt2dLibraries.gmk .
>>
> 
> Hi Yasumasa , are you fine with the rest of the patch ?

Yes, looks good to me.


> Regarding  disabling of stringop-truncation  , I first  disabled it only for liblcms but this was not sufficient.
> (there is indeed another change   8220074   for liblcms that disabled this warning for GCC 8.3 )
>   There are more issues related to  the no-stringop-truncation  warning and I did not even found a good place to disable them locally in a nice way .
>   (some strange jvmti related test coding I think those are single file compilations , no real lib??)

I guess the libraries which you mean are located to build/linux-x86_64-server-fastdebug/images/test/hotspot/jtreg/native .
If so, do you see stringop-truncation error on JVMTI tests only? Have you considered to use pragma?
If you don't want to use pragma, can you use CFLAGS in JtregNativeHotspot.gmk ?

   https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/file/0f3f7aa2ef34/make/test/JtregNativeHotspot.gmk#l210


Thanks,

Yasumasa


> Best regards, Matthias
> 
> 
>> On 2021/05/12 16:47, Baesken, Matthias wrote:
>>> Hello,  I  please review the backport of  8232084  to jdk11 .
>>>
>>> This is needed to make  jdk11  buildable with gcc-9   (tested on linux  x86_64) .
>>>
>>> Changes in the jdk11 backport  compared to jdk/jdk :
>>>
>>> hotspot/cpu/x86/macroAssembler_x86.hpp  change is not needed in jdk11
>>>
>>> src/hotspot/share/utilities/compilerWarnings_gcc.hpp   does not exist in jdk11 so the  compilerWarnings_gcc.hpp change  goes to  compilerWarnings.hpp
>>>
>>> additionally to be able to build with gcc-9   in make/autoconf/flags-cflags.m4  -Wno-stringop-truncation  has to be set (issues in jvmti test coding and liblcms )
>>
>> I heard that we should disable warnings as narrow as possible in the review. (I forget what ticket it is about)
>> However, to disable warnings in third party libraries like liblcms, we can disable them at the makefile for them.
>> In case of liblcms, it is prefer to disable stringop-truncation at Awt2dLibraries.gmk .
> 
>   
>