[jdk11u-dev] RFR: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed [v2]

Thomas Stuefe stuefe at openjdk.java.net
Thu Nov 11 14:32:01 UTC 2021


> Hi,
> 
> I'd like to backport "JDK-8263728: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed", since it prevents sporadic gtest errors.
> 
> Original commit: https://github.com/openjdk/jdk/commit/8c1112a6
> 
> This one is not a clean backport:
> - `vmError.cpp` changed slightly, since https://bugs.openjdk.java.net/browse/JDK-8258479 did some code cleanups for JDK17
> - more importantly, this patch touches `os::abort()`. That function had been unified into `os_posix.cpp` for all posix platforms with https://bugs.openjdk.java.net/browse/JDK-8263564 for JDK 17. I briefly considered backporting JDK-8263564, but decided against it since it is too invasive and unnecessary. Instead, I changed the various os::abort() implementations for all individual OSes, including Solaris.
> 
> Tests: Nightlies at SAP, GHAs.
> 
> Thanks, Thomas

Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:

  remove stray edit to os_posix.cpp

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk11u-dev/pull/590/files
  - new: https://git.openjdk.java.net/jdk11u-dev/pull/590/files/45b85b59..90f9afbc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=590&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=590&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk11u-dev/pull/590.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/590/head:pull/590

PR: https://git.openjdk.java.net/jdk11u-dev/pull/590


More information about the jdk-updates-dev mailing list