[jdk11u-dev] RFR: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

[Thomas Stuefe]

On Thu, 11 Nov 2021 13:30:28 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Hi,
>> 
>> I'd like to backport "JDK-8263728: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed", since it prevents sporadic gtest errors.
>> 
>> Original commit: https://github.com/openjdk/jdk/commit/8c1112a6
>> 
>> This one is not a clean backport:
>> - `vmError.cpp` changed slightly, since https://bugs.openjdk.java.net/browse/JDK-8258479 did some code cleanups for JDK17
>> - more importantly, this patch touches `os::abort()`. That function had been unified into `os_posix.cpp` for all posix platforms with https://bugs.openjdk.java.net/browse/JDK-8263564 for JDK 17. I briefly considered backporting JDK-8263564, but decided against it since it is too invasive and unnecessary. Instead, I changed the various os::abort() implementations for all individual OSes, including Solaris.
>> 
>> Tests: Nightlies at SAP, GHAs.
>> 
>> Thanks, Thomas
>
> Thanks for the explanation ... in the meantime I'm aware of that issue on windows, too!

Thanks @GoeLin . Waiting for approval in JBS.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/590