[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v11]

[Andrew Dinn]

On Sat, 13 Nov 2021 17:18:54 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> It seems that MSVC gives an [error](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/fatal-error-c1010?view=msvc-170) if a PCH specified on the command line is not included in the file. Since the use of precompiled headers is enabled by default, this compilation command gets the same PCH related arguments as the others. An alternative solution I found to be working is to add this file to the PCH exclude list here: [make/hotspot/lib/JvmOverrideFiles.gmk#L191](https://github.com/openjdk/jdk11u-dev/blob/6ec651fdc1c5ea0fe22731077446de1dd39cb24d/make/hotspot/lib/JvmOverrideFiles.gmk#L191), and then the include can be removed. Which one do you prefer?
>
> This change is OK, then. Let it stay.

It would help avoid problems later if a comment was added to say that this include is needed to keep MSVC happy. Otherwise someone might delete it.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301