[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v3]

Fri Oct 1 15:04:33 UTC 2021

On Thu, 2 Sep 2021 22:10:23 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> [...] where pusha is :
> 
> void MacroAssembler::pusha() { push(0x7fffffff, sp); }
> 
> [...]

Nice catch!

I'm not sure if this should go as part of this PR. The same problem exists in jdk-tip and therefore should be addressed there first:
https://github.com/openjdk/jdk/blob/c05dc268acaf87236f30cf700ea3ac778e3b20e5/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L1859-L1865

On jdk-tip there is only one usage left in the template interpreter generator: https://github.com/openjdk/jdk/blob/c05dc268acaf87236f30cf700ea3ac778e3b20e5/src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp#L1400-L1404

Seems like the code path is uncommon, but we should still fix it imho.

What do you think?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301