[jdk11u-dev] RFR: 8248817: Windows: Improving common cross-platform code

[Martin Doerr]

On Sun, 29 Aug 2021 19:03:52 GMT, Reka Kovacs <github.com+25946952+rnkovacs at openjdk.org> wrote:

> Not a clean backport. Differences to the original commit:
> 
> - The removed lines in `stubGenerator_x86_32.cpp` and `stubGenerator_x86_64.cpp` are slightly different on tip (comments - [JDK-8234563](https://bugs.openjdk.java.net/browse/JDK-8234563), MP checks - [JDK-8188764](https://bugs.openjdk.java.net/browse/JDK-8188764)), but fundamentally the same.
> - Changes to `add`, `xchg` and `cmpxchg` definitions in `atomic_windows_x86.hpp` needed to be adjusted to keep the original parameter orders (changed in JDK 14 by [JDK-8234563](https://bugs.openjdk.java.net/browse/JDK-8234563)).
> 
> Changes to `os_windows_x86.cpp` and `os_windows_x86.hpp` could be applied cleanly.
> 
> This is part of the Windows/AArch64 port.

Changing so much x86 code in an Windows aarch64 preparation change is not so nice, but it's better than integrating half changes IMHO. Looks good and all tests are green. Good work!

-------------

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/300