[jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2]

[Andrew Haley]

On Fri, 27 Aug 2021 16:50:41 GMT, Reka Kovacs <github.com+25946952+rnkovacs at openjdk.org> wrote:

>> Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit:
>> 
>> - This is the first time we disable an MSVC warning for hotspot in 11, so in  `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line.
>> - We disable the same warning in  `make/hotspot/lib/CompileGtest.gmk`.
>> - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR).
>> - <s>Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215.</s>
>> - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.)
>> 
>> This is part of the Windows/AArch64 port.
>
> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport d2812f780e87511736f2d41bc57a69c2a898b583

make/hotspot/lib/CompileGtest.gmk line 81:

> 79:         tautological-undefined-compare $(BUILD_LIBJVM_DISABLED_WARNINGS_clang), \
> 80:     DISABLED_WARNINGS_solstudio := identexpected, \
> 81:     DISABLED_WARNINGS_microsoft := 4146, \

What does this do? Need a comment here.

make/hotspot/lib/CompileJvm.gmk line 167:

> 165:     DISABLED_WARNINGS_xlc := 1540-0216 1540-0198 1540-1090 1540-1639 \
> 166:         1540-1088 1500-010, \
> 167:     DISABLED_WARNINGS_microsoft := 4146, \

Here too.

src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1336:

> 1334:   //   used by generate_conjoint_int_oop_copy().
> 1335:   //
> 1336:   address generate_disjoint_copy(int size, bool aligned, bool is_oop, address *entry,

size_t is correct here.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/280