[jdk17u] RFR: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl

Christoph Langer clanger at openjdk.java.net
Wed Oct 6 05:28:18 UTC 2021


On Tue, 5 Oct 2021 22:06:30 GMT, Mat Carter <github.com+54955201+macarte at openjdk.org> wrote:

> Building upon [JDK-8250521](https://bugs.openjdk.java.net/browse/JDK-8250521) which only added support for NIOSocketImpl (default), add support to PlainSocketImpl which can be selected as the implementation.
> 
> This is required for the backport to 11u where NIOSocketImpl doesn't exist and PlainSocketImpl is the default implementation
> 
> To test on windows run with -Djdk.net.usePlainSocketImpl
> 
> Before fix loopback timeouts:
> 
> - NioSocketImpl ~200ms
> - PlainSocketImpl ~22200ms
> 
> After fix loopback timeouts:
> 
> - NioSocketImpl ~200ms
> - PlainSocketImpl ~200ms

This looks good to me.
I'll run it through SAP's nightly regression tests and will post the result tomorrow.
I also see that you didn't enable GitHub Actions on your repository. I suggest to do that (also for future PRs) and maybe trigger GHA for this PR by e.g. merging with master (in case it changes) or amending the current commit and force-pushing

-------------

Marked as reviewed by clanger (Reviewer).

PR: https://git.openjdk.java.net/jdk17u/pull/153


More information about the jdk-updates-dev mailing list