[jdk11u-dev] RFR: 8248817: Windows: Improving common cross-platform code

Christoph Langer clanger at openjdk.java.net
Thu Oct 14 10:38:03 UTC 2021


On Thu, 14 Oct 2021 10:11:16 GMT, Andrew Haley <aph at openjdk.org> wrote:

> > I think technically this one is reviewed but maintainers now need to take the decision whether to allow this or reject as being to much of churn. I suggest you add the fix request data to JBS and we will then take a decision.
> 
> It's not technically reviewed: even if two people approve it, objections must be addressed.
> 
> I am still of the belief that the AArch64 code can be integrated without touching the x86 atomics. If I had a WIndows AArch64 system and enough time to figure out how to build and debug this stuff I'd do it myself, just to prove the point.
> 
> Hint: put the common atomic stuff in a separate place. Call it from the AArch64 code, but do not touch the x86 code.

OK, I somehow overread the technical suggestion to try to find a way to do the changes only in the aarch64 code and leaving x86 alone. So, yes, if that would be possible it would probably be a more acceptable way of doing this backport.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/300


More information about the jdk-updates-dev mailing list